Add twimoji #105
Add twimoji #105
Conversation
|
https://www.npmjs.com/package/emoji or https://www.npmjs.com/package/node-emoji no good? |
|
Gonna merge this one in for now, as it's probably better than no emojis. Feel free to open a PR to swap the library. |
| return localStorage[cookieName]; | ||
| }; | ||
| }); | ||
|
|
There was a problem hiding this comment.
Is this supposed to be here?
|
Not yet. That's in fact the code @run1t wrote to help me to create the profile menu entry in the new layout 3 branch. |
|
Ok, cool. @run1t, can you remove that block from tinder-desktop.common.js then? Also, can we add the emoji filter to the Profile / Swipe bios? |
|
Yep will do that |
desktop-app/index.html
Outdated
| <link rel="stylesheet" href="css/sweet-alert.css"/> | ||
|
|
||
|
|
||
| <script src="https://twemoji.maxcdn.com/2/twemoji.min.js"></script> |
There was a problem hiding this comment.
twemoji it's really heavy (almost 300mb) that's why I use a CDN here.
There was a problem hiding this comment.
Holy guacamole. The source, or the dist?!?!
There was a problem hiding this comment.
the bower install twemojiso I guess the dist
There was a problem hiding this comment.
It's just the source for dev. Alright, let's leave it as a CDN resource for now...
There was a problem hiding this comment.
There's also privacy implications, maybe we want to ship it locally and avoid outside dependencies?
|
|
5 participants
Closes #23.